Compilation warning with MSVC in pg_depend.c

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>
Subject: Compilation warning with MSVC in pg_depend.c
Date: 2017-04-07 03:03:47
Message-ID: CAB7nPqT5FakguBb4_NiD7voSCFAgQGvp93igiN3z_VoouAAGPw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi all,

I am getting the following warning with MSVC 2010 for what is a result
of 3217327 (identity columns):
c:\users\michael\git\postgres\src\backend\catalog\pg_depend.c(615):
warning C4715: 'getOwnedSequence' : not all control paths return a
value [C:\Users\michael\git\postgres\postgres.vcxproj]

I agree that this compiler is dumb after looking at the code, but
could it be possible to silence this warning with something like the
attached?

Thanks,
--
Michael
VMware vCenter Server
www.vmware.com

Attachment Content-Type Size
seq-msvc-warning.patch application/octet-stream 469 bytes

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Ashutosh Bapat 2017-04-07 03:03:56 Re: No-op case in ExecEvalConvertRowtype
Previous Message Tom Lane 2017-04-07 02:54:17 Re: Time to change pg_regress diffs to unified by default?