Re: subxcnt defined as signed integer in SnapshotData and SerializeSnapshotData

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Simon Riggs <simon(at)2ndquadrant(dot)com>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: subxcnt defined as signed integer in SnapshotData and SerializeSnapshotData
Date: 2015-05-13 16:17:53
Message-ID: CAB7nPqT+H4e_pjK_eyyfA_NrygW8vmEn0O+9rsDdDXmAapqwvg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, May 14, 2015 at 1:03 AM, Michael Paquier wrote:
> On Thu, May 14, 2015 at 12:02 AM, Robert Haas wrote:
>> I'm just going to remove the useless assertion for now. What you're
>> proposing here may (or may not) be worth doing, but it carries a
>> non-zero risk of breaking something somewhere, if anyone is relying on
>> the signed-ness of that type. Removing the assertion is definitely
>> safe.
>
> Fine for me. That's indeed possible for an extension.

Btw, I think that your commit message should have given some credit to
Coverity for finding the problem. Not a big deal though.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Dunstan 2015-05-13 16:20:27 Re: Triaging the remaining open commitfest items
Previous Message Stephen Frost 2015-05-13 16:15:43 Re: Triaging the remaining open commitfest items