Re: COPY FREEZE has no warning

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Bruce Momjian <bruce(at)momjian(dot)us>, Andres Freund <andres(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: COPY FREEZE has no warning
Date: 2013-01-26 00:45:30
Message-ID: CAB7nPqSzHtpR_epYuDpi3TK8nKh87dSyurBz7WJSDkNDNCzg3w@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sat, Jan 26, 2013 at 2:42 AM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:

> On Fri, Jan 25, 2013 at 11:59 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> > Bruce Momjian <bruce(at)momjian(dot)us> writes:
> >> On Fri, Jan 25, 2013 at 02:48:37AM +0100, Andres Freund wrote:
> >>> FWIW, and I won't annoy anyone further after this email, now that its
> >>> deterministic, I still think that this should be an ERROR not a
> WARNING.
> >
> >> As the FREEZE is just an optimization, I thought NOTICE, vs WARNING or
> >> ERROR was fine. If others want this changed, please reply.
> >
> > The previous argument about it was "if you bothered to specify FREEZE,
> > you probably really want/need that behavior". So I can definitely see
> > Andres' point. Perhaps WARNING would be a suitable compromise?
>
> I'll vote for ERROR. I don't see why this sound be a best-effort thing.
>
+ 1. I was surprised to see COPY FREEZE failing silently when testing the
feature. An ERROR would be suited.
--
Michael Paquier
http://michael.otacoo.com

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2013-01-26 01:37:32 Re: Hanging backends and possible index corruption
Previous Message Tom Lane 2013-01-26 00:29:59 Re: LATERAL, UNNEST and spec compliance