From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
---|---|
To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
Cc: | Jeff Janes <jeff(dot)janes(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: pgcrypto: add s2k-count |
Date: | 2016-02-12 00:16:58 |
Message-ID: | CAB7nPqSxz4mboKCtb8fPS=s7Y35yNNZMUc1prvm95siegpHiAQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Fri, Feb 12, 2016 at 2:46 AM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> On Wed, Feb 10, 2016 at 12:44 AM, Jeff Janes <jeff(dot)janes(at)gmail(dot)com> wrote:
>> I did not bump the extension version. I realized the migration file
>> would be empty, as there no change to SQL-level functionality (the new
>> s2k-count is parsed out of a string down in the C code). Since only
>> one version of contrib extensions binary object files are installed in
>> any given postgres installation, people using the newer binary gets
>> the feature even if they have not updated the extension version. So I
>> don't know if it makes sense to bump the version if people inherently
>> get the feature anyway.
>
> There's zero reason to bump the extension version if the SQL interface
> hasn't changed.
>
> (I have no opinion on the underlying patch.)
+1.
--
Michael
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2016-02-12 00:18:46 | Re: NextXID format change (was Re: exposing pg_controldata and pg_config as functions) |
Previous Message | Kouhei Kaigai | 2016-02-12 00:06:27 | Re: CustomScan in a larger structure (RE: CustomScan support on readfuncs.c) |