Re: New pg_lsn type doesn't have hash/btree opclasses

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Craig Ringer <craig(at)2ndquadrant(dot)com>
Cc: Andres Freund <andres(at)2ndquadrant(dot)com>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com>
Subject: Re: New pg_lsn type doesn't have hash/btree opclasses
Date: 2014-05-07 06:27:54
Message-ID: CAB7nPqStrxb3xxBRHzURnTJMu2bBiWuwpqg06hWHxNXv-+kM=g@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, May 7, 2014 at 1:21 PM, Craig Ringer <craig(at)2ndquadrant(dot)com> wrote:
> On 05/07/2014 07:16 AM, Michael Paquier wrote:
>> On Wed, May 7, 2014 at 8:07 AM, Andres Freund <andres(at)2ndquadrant(dot)com> wrote:
>>> On 2014-05-06 22:49:07 +0900, Michael Paquier wrote:
>>> FWIW, the format you're using makes applying the patch including the
>>> commit message relatively hard. Consider using git format-patch.
>
>> Could you be clearer? By applying a filterdiff command or by using git
>> diff? The latter has been used for this patch.
>
> git format-patch -1
>
> is usually what you want to emit a patch for the top commit. To produce
> a patchset between the current branch and master:
>
> git format-patch master
>
> It doesn't use context diff, but I think people here have mostly stopped
> caring about that now (?).
Thanks for the details, I didn't know this subcommand of git.
--
Michael

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Kouhei Kaigai 2014-05-07 07:17:02 Re: [v9.5] Custom Plan API
Previous Message Simon Riggs 2014-05-07 06:18:51 Re: [v9.5] Custom Plan API