From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
---|---|
To: | Stephen Frost <sfrost(at)snowman(dot)net> |
Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: LOCK TABLE Permissions |
Date: | 2015-05-11 19:52:03 |
Message-ID: | CAB7nPqSt_Q=_G26NoxnQwj+6316TvwV0MGCiaP3M1e6ojDKjLA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Tue, May 12, 2015 at 4:01 AM, Stephen Frost <sfrost(at)snowman(dot)net> wrote:
> * Michael Paquier (michael(dot)paquier(at)gmail(dot)com) wrote:
>> On Mon, May 11, 2015 at 10:32 PM, Stephen Frost <sfrost(at)snowman(dot)net> wrote:
>> > Now for a blast from the past... This came up again on IRC recently and
>> > reminded me that I ran into the same issue a couple years back. Updated
>> > patch includes the refactoring suggested and includes documentation.
>> >
>> > Barring objections, I'll push this later today.
>>
>> Small suggestion: a test case in src/test/isolation?
>
> This is entirely a permissions-related change and src/test/isolation is
> for testing concurrent behavior, not about testing permissions.
>
> I'm not saying that we shouldn't have more tests there, but it'd not
> be appropriate for this particular patch.
Perhaps. Note that we could have tests of this type though in lock.sql:
create role foo login;
create table aa (a int);
grant insert on aa TO foo;
\c postgres foo
begin;
insert into aa values (1);
lock table aa in row exclusive mode; -- should pass
Just mentioning it for the sake of the archives, I cannot work on that for now.
Regards,
--
Michael
From | Date | Subject | |
---|---|---|---|
Next Message | Stephen Frost | 2015-05-11 19:53:36 | Re: LOCK TABLE Permissions |
Previous Message | Stephen Frost | 2015-05-11 19:45:01 | Re: LOCK TABLE Permissions |