From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
---|---|
To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
Cc: | Kevin Grittner <kgrittn(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Steve Singer <steve(at)ssinger(dot)info>, Kevin Grittner <kgrittn(at)ymail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: snapshot too old, configured by time |
Date: | 2016-03-11 14:33:59 |
Message-ID: | CAB7nPqStAKe-QHq1YcWxbZJtG=i74JvB71m7UTqQPUxom3d_qg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Fri, Mar 11, 2016 at 2:35 PM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> On Thu, Mar 3, 2016 at 2:40 PM, Kevin Grittner <kgrittn(at)gmail(dot)com> wrote:
>> Thanks for the tips. Attached is a minimal set of isolation tests.
>> I can expand on it if needed, but wanted:
>>
>> (1) to confirm that this is the right way to do this, and
>>
>> (2) how long people were willing to tolerate these tests running.
>>
>> Since we're making this time-based (by popular demand), there must
>> be delays to see the new behavior. This very minimal pair of tests
>> runs in just under one minute on my i7. Decent coverage of all the
>> index AMs would probably require tests which run for at least 10
>> minutes, and probably double that. I don't recall any satisfactory
>> resolution to prior discussions about long-running tests.
>>
>> This is a follow-on patch, just to add isolation testing; the prior
>> patch must be applied, too.
>
> Michael, any chance that you could take a look at what Kevin did here
> and see if it looks good?
OK, I am marking this email. Just don't expect any updates from my
side until mid/end of next week.
> I'm sure the base patch could use more review too, if anyone can find the time.
I guess I am going to need to look at the patch if if feedback for the
tests is needed.. There is no point in looking at the tests without
poking at the patch.
--
Michael
From | Date | Subject | |
---|---|---|---|
Next Message | David Steele | 2016-03-11 14:45:46 | Re: [PROPOSAL] Client Log Output Filtering |
Previous Message | Petr Jelinek | 2016-03-11 14:24:48 | Re: [PATCH] Logical decoding support for sequence advances |