Re: [PATCH] add ssl_protocols configuration option

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Alex Shulgin <ash(at)commandprompt(dot)com>
Cc: Dag-Erling Smørgrav <des(at)des(dot)no>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] add ssl_protocols configuration option
Date: 2014-12-15 03:02:07
Message-ID: CAB7nPqSosOBu4ia04-nX8RKnzfWjy==2KA3uc2QtbYFrZqTX-w@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Nov 27, 2014 at 8:51 PM, Alex Shulgin <ash(at)commandprompt(dot)com> wrote:
>
> Dag-Erling Smørgrav <des(at)des(dot)no> writes:
>
>> Alex Shulgin <ash(at)commandprompt(dot)com> writes:
>>> OK, looks like I've come up with something workable: I've added
>>> sslprotocol connection string keyword similar to pre-existing
>>> sslcompression, etc. Please see attached v2 of the original patch.
>>> I'm having doubts about the name of openssl.h header though,
>>> libpq-openssl.h?
>>
>> Perhaps ssloptions.[ch], unless you plan to add non-option-related code
>> there later?
>
> I don't think anything else than common options-related code fits in
> there, so ssloptions.c makes sense to me.
>
>> BTW, there is no Regent code in your openssl.c, so the copyright
>> statement is incorrect.
>
> Good catch, I just blindly copied that from some other file.
There have been arguments in favor and against this patch... But
marking it as returned with feedback because of a lack of activity in
the last couple of weeks. Feel free to update if you think that's not
correct, and please move this patch to commit fest 2014-12.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2014-12-15 03:13:38 Re: WIP: dynahash replacement for buffer table
Previous Message Michael Paquier 2014-12-15 02:55:29 Re: WIP: multivariate statistics / proof of concept