Logical replication launcher's bgworker enabled by default, and max_logical_replication_workers

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>
Subject: Logical replication launcher's bgworker enabled by default, and max_logical_replication_workers
Date: 2017-01-23 04:37:04
Message-ID: CAB7nPqSnZJADTCV9eDiNANiWcsicg8ecMhi+_4UUKLDGxrOwuQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi all,

When spawning a new instance, I found the following thing, which is
surprising at first sight:
postgres: bgworker: logical replication launcher

There is perhaps no problem to keep that enabled by default until the
release 10 wraps to give it some buildfarm coverage similarly to what
has been done last year for parallel query, but what is surprising me
is that even if wal_level is *not* logical this gets started. I think
that something like the patch attached is needed, so as
ApplyLauncherRegister() is a noop if wal_level < logical.

In the same range of thoughts, it is also surprising to have the
default value of max_logical_replication_workers set to 4, I would
have thought that for a feature that has created more than 13k of code
diffs, it would be disabled by default.

Thanks,
--
Michael

Attachment Content-Type Size
logirep-bgworker.patch application/x-download 1.3 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Dilip Kumar 2017-01-23 04:42:44 Re: Parallel bitmap heap scan
Previous Message Craig Ringer 2017-01-23 04:34:27 Re: [PATCH] Fix minor race in commit_ts SLRU truncation vs lookups