Re: increasing the default WAL segment size

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Beena Emerson <memissemerson(at)gmail(dot)com>
Cc: Jim Nasby <Jim(dot)Nasby(at)bluetreble(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: increasing the default WAL segment size
Date: 2017-01-18 01:54:36
Message-ID: CAB7nPqSkV7SBO759U6dLTcnaH2YaSUXgMdbfBgxDMoV_bLczOw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

On Tue, Jan 17, 2017 at 7:19 PM, Beena Emerson <memissemerson(at)gmail(dot)com> wrote:
> PFA the patch with the documentation included.

It is usually better to keep doc lines under control of 72-80
characters if possible.

+ /* column 1: Wal segment size */
+ len = strlen(value);
+ pq_sendint(&buf, len, 4);
+ pq_sendbytes(&buf, value, len);
Bip. Error. This is a parameter value, not the WAL segment size.

Except those minor points this works as expected, and is consistent
with non-replication sessions, so that's nice by itself:
=# create user toto replication login;
CREATE ROLE

$ psql "replication=1" -U toto
=> SHOW foo;
ERROR: 42704: unrecognized configuration parameter "foo"
LOCATION: GetConfigOptionByName, guc.c:7968
Time: 0.245 ms
=> SHOW log_directory;
ERROR: 42501: must be superuser to examine "log_directory"
LOCATION: GetConfigOptionByName, guc.c:7974

I think that we could get a committer look at that at the least.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2017-01-18 02:06:14 Re: Patch to implement pg_current_logfile() function
Previous Message Nikita Glukhov 2017-01-18 01:42:01 [PATCH] kNN for btree