Re: Missing importing option of postgres_fdw

On Mon, Apr 27, 2015 at 3:15 PM, Etsuro Fujita
<fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp> wrote:
> Hi,
>
> I noticed that there is no postgres_fdw option to control whether check
> constraints on remote tables are included in the definitions of foreign
> tables imported from a remote PG server when performing IMPORT FOREIGN
> SCHEMA, while we now allow check constraints on foreign tables.
>
> Attached is a patch for that. I'll add this to the next CF.

I guess that the addition of this option makes sense, but I think that
this patch is doing it wrong by using ALTER FOREIGN TABLE and by
changing the queries authorized in ImportForeignSchema(). The point of
IMPORT FOREIGN SCHEMA is to authorize only CREATE FOREIGN TABLE and
not other types of queries, not to mention that CREATE FOREIGN TABLE
supports the definitions of constraints at table and column-level.
Logically, this patch should just create diffs with postgres_fdw and
nothing else.
Regards,
--
Michael