Re: NULL-pointer check and incorrect comment for pstate in addRangeTableEntry

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Greg Stark <stark(at)mit(dot)edu>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: NULL-pointer check and incorrect comment for pstate in addRangeTableEntry
Date: 2015-03-11 23:47:10
Message-ID: CAB7nPqSbt80cvgCNGE7XCf2-aBMQ1hQYgnXUYg05i0-TBXDx_A@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Mar 12, 2015 at 4:36 AM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> On Wed, Mar 4, 2015 at 7:38 AM, Michael Paquier
> <michael(dot)paquier(at)gmail(dot)com> wrote:
>> On Wed, Mar 4, 2015 at 9:12 PM, Greg Stark <stark(at)mit(dot)edu> wrote:
>>> This sounded familiar... I pointed out the same thing a while back and Tom
>>> had some feedback on what to do about it:
>>>
>>> http://www.postgresql.org/message-id/23294.1384142407@sss.pgh.pa.us
>>
>> Translated into code I guess that this gives the attached patch.
>
> Looks fine to me, so committed.

Thanks for picking this up.
--
Michael

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2015-03-11 23:49:36 Re: Precedence of standard comparison operators
Previous Message Tom Lane 2015-03-11 23:38:11 Re: Precedence of standard comparison operators