Re: NULL-pointer check and incorrect comment for pstate in addRangeTableEntry

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
Cc: Greg Stark <stark(at)mit(dot)edu>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: NULL-pointer check and incorrect comment for pstate in addRangeTableEntry
Date: 2015-03-11 19:36:07
Message-ID: CA+TgmobRs1CJXmgS4Xt2s3T9r8WR=0vfbttwgWqZu+J9M59suw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Mar 4, 2015 at 7:38 AM, Michael Paquier
<michael(dot)paquier(at)gmail(dot)com> wrote:
> On Wed, Mar 4, 2015 at 9:12 PM, Greg Stark <stark(at)mit(dot)edu> wrote:
>> This sounded familiar... I pointed out the same thing a while back and Tom
>> had some feedback on what to do about it:
>>
>> http://www.postgresql.org/message-id/23294.1384142407@sss.pgh.pa.us
>
> Translated into code I guess that this gives the attached patch.

Looks fine to me, so committed.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tomas Vondra 2015-03-11 19:48:12 using CustomScan to inject nodes into the plan
Previous Message Robert Haas 2015-03-11 19:14:59 Re: Strange assertion using VACOPT_FREEZE in vacuum.c