Re: BUG #14941: Vacuum crashes

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: "Bossart, Nathan" <bossartn(at)amazon(dot)com>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, "lyes(dot)amd(at)gmail(dot)com" <lyes(dot)amd(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, "pgsql-bugs(at)postgresql(dot)org" <pgsql-bugs(at)postgresql(dot)org>
Subject: Re: BUG #14941: Vacuum crashes
Date: 2017-12-11 04:25:22
Message-ID: CAB7nPqSaNoS_iz8m+kz8dOy8kpPiJgN3CpM+RbYLdLt+jbTyyA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

On Sat, Dec 2, 2017 at 6:16 AM, Bossart, Nathan <bossartn(at)amazon(dot)com> wrote:
> On 12/1/17, 3:04 PM, "Robert Haas" <robertmhaas(at)gmail(dot)com> wrote:
>> Seems entirely reasonable to me, provided that we only update the
>> extensible-options syntax:
>>
>> VACUUM [ ( option [, ...] ) ] [ table_and_columns [, ...] ]
>>
>> I don't want to add any more options to the older syntax:
>>
>> VACUUM [ FULL ] [ FREEZE ] [ VERBOSE ] [ ANALYZE ] [ table_and_columns [, ...] ]
>
> Right. This seems like the right path forward to me, as the
> VACUUM documentation states that the unparenthesized syntax is
> deprecated, and the DISABLE_PAGE_SKIPPING option was not added
> to the old syntax, either.

Yeah, the exact same discussion has happened when what has become
DISABLE_PAGE_SKIPPING was discussed for the freeze map.
--
Michael

In response to

Browse pgsql-bugs by date

  From Date Subject
Next Message Michael Paquier 2017-12-11 05:13:21 Re: BUG #14941: Vacuum crashes
Previous Message Amit Langote 2017-12-11 01:08:53 Re: [BUGS] BUG #14866: The generated constraint in the typed table causes the server to crash

Browse pgsql-hackers by date

  From Date Subject
Next Message Rushabh Lathia 2017-12-11 04:49:06 Re: [HACKERS] Parallel tuplesort (for parallel B-Tree index creation)
Previous Message Amit Kapila 2017-12-11 04:07:39 Re: [HACKERS] parallel.c oblivion of worker-startup failures