Re: Exclude pg_internal.init from base backup

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: David Steele <david(at)pgmasters(dot)net>
Cc: Simon Riggs <simon(at)2ndquadrant(dot)com>, Magnus Hagander <magnus(at)hagander(dot)net>, Petr Jelinek <petr(dot)jelinek(at)2ndquadrant(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Exclude pg_internal.init from base backup
Date: 2017-11-07 23:21:49
Message-ID: CAB7nPqSZnxwCrcS5vWE5R6_b+59H5+nj02oyff17oO-BXDKp2g@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Nov 8, 2017 at 1:42 AM, David Steele <david(at)pgmasters(dot)net> wrote:
> On 11/7/17 11:03 AM, Simon Riggs wrote:
>> On 5 November 2017 at 11:55, Magnus Hagander <magnus(at)hagander(dot)net> wrote:
>>>
>>> So +1 for documenting the difference in how these are handled, as this is
>>> important to know for somebody writing an external tool for it.
>>
>> Changes made, moving to commit the attached patch.
>
> Thanks, Simon! This was on my to do list today -- glad I checked my
> email first.

<para>
+ <filename>pg_internal.init</filename> files can be omitted from the
+ backup whenever a file of that name is found. These files contain
+ relation cache data that is always rebuilt when recovering.
+ </para>
Do we want to mention in the docs that the same decision-making is
done for *all* files with matching names, aka the fact that if a file
is listed and found in a sub-folder it is skipped? postmaster.opts or
similar friends are unlikely to be found in anything but the root of
the data folder, still the upthread argument of documenting precisely
what basebackup.c does sounded rather convincing to me.
--
Michael

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Nico Williams 2017-11-07 23:29:22 Re: MERGE SQL Statement for PG11
Previous Message Michael Paquier 2017-11-07 23:17:56 Re: Remove secondary checkpoint