From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Magnus Hagander <magnus(at)hagander(dot)net>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Why doesn't src/backend/port/win32/socket.c implement bind()? |
Date: | 2016-04-14 23:13:08 |
Message-ID: | CAB7nPqSY2q6t1S-zQnjogDCTox2sv14w2jPdthYs3CUZ8UK91Q@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Fri, Apr 15, 2016 at 12:13 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Michael Paquier <michael(dot)paquier(at)gmail(dot)com> writes:
>> On Thu, Apr 14, 2016 at 9:38 AM, Michael Paquier
>> <michael(dot)paquier(at)gmail(dot)com> wrote:
>>> IO::Socket::INET is another option, but I am not seeing it in perl <
>>> 5.12, and that's not part of ActivePerl, which makes life harder on
>>> Windows. Socket is available on both. Does that address your concerns?
>
>> And this gives the patch attached, just took the time to hack it.
>
> I think this is a good idea, but (1) I'm inclined not to restrict it to
> Windows, and (2) I think we should hold off applying it until we've seen
> a failure or two more, and can confirm whether d1b7d4877 does anything
> useful for the error messages.
Both arguments are fine for me.
--
Michael
From | Date | Subject | |
---|---|---|---|
Next Message | Peter Geoghegan | 2016-04-14 23:42:15 | Re: Draft release notes for next week's releases |
Previous Message | Peter Geoghegan | 2016-04-14 23:03:51 | Obsolete comment within fmgr.c |