| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
| Cc: | Simon Riggs <simon(at)2ndquadrant(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-committers(at)postgresql(dot)org |
| Subject: | Re: pgsql: Separate block sampling functions |
| Date: | 2015-05-15 11:50:34 |
| Message-ID: | CAB7nPqSVfXy_k0Lx_Ehn+TBq5V1ajccH05K7zgC-EK-mSzcRAg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
On Fri, May 15, 2015 at 8:44 PM, Andrew Dunstan <andrew(at)dunslane(dot)net> wrote:
>
> On 05/15/2015 06:04 AM, Simon Riggs wrote:
>>
>> On 15 May 2015 at 04:59, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us
>> <mailto:tgl(at)sss(dot)pgh(dot)pa(dot)us>> wrote:
>>
>> The difference there was that that was specifically adding a new
>> feature
>> of value to FDWs. This is just drive-by breakage.
>>
>>
>> I think that comment is reasonable. I will continue with my commits of
>> tablesample, then return to see if we can improve/revert the API breakage.
>>
>>
>
>
> OK, good, but I'm not going to accept Michael's pull request until the API
> is stable.
Well, I guess that this is going to be incorrect in any case now.
Still any API change can be done cleanly in a matter of minutes for
this FDW.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fujii Masao | 2015-05-15 12:05:24 | Re: pgsql: Allow GiST distance function to return merely a lower-bound. |
| Previous Message | Andrew Dunstan | 2015-05-15 11:44:15 | Re: pgsql: Separate block sampling functions |