Re: Renaming of pg_xlog and pg_clog

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Craig Ringer <craig(dot)ringer(at)2ndquadrant(dot)com>
Cc: Jim Nasby <Jim(dot)Nasby(at)bluetreble(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Andres Freund <andres(at)anarazel(dot)de>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
Subject: Re: Renaming of pg_xlog and pg_clog
Date: 2016-08-30 02:04:31
Message-ID: CAB7nPqSUE4Zp=W798ryj=PuD0d7Jwgj85drZ_ENS2RZ0=W6new@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Aug 29, 2016 at 9:39 PM, Craig Ringer
<craig(dot)ringer(at)2ndquadrant(dot)com> wrote:
> Cool. I'll mark as waiting on author pending that.
>
> It'll be good to get this footgun put away.

OK, so done. I have put the renaming of pg_xlog to pg_wal on top patch
stack as that's the one making no discussion it seems: a lot of people
like pg_wal. I have added as well handling for the renaming in
pg_basebackup by using PQserverVersion. One thing to note is that a
connection needs to be made to the target server *before* creating the
soft link of pg_xlog/pg_wal because we need to know the version of the
target server. pg_upgrade is handled as well. And that's all in 0001.

Patch 0002 does pg_clog -> pg_trans, "trans" standing for
"transaction". Switching to pg_trans_status or pg_xact_status is not
that complicated to change anyway...
--
Michael

Attachment Content-Type Size
0002-Rename-pg_clog-to-pg_trans.patch application/x-patch 31.6 KB
0001-Rename-pg_xlog-to-pg_wal.patch application/x-patch 69.3 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2016-08-30 02:23:48 Re: Write Ahead Logging for Hash Indexes
Previous Message Etsuro Fujita 2016-08-30 01:55:28 Re: Odd oid-system-column handling in postgres_fdw