| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Small typo in timeline.h regarding the meaning of infinity for timeline history entry |
| Date: | 2015-09-10 05:37:21 |
| Message-ID: | CAB7nPqSSzK0Pgqxg6D+LzQEmaARVktYTBZq9QCQ5+hDuKRAFbQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi all,
timeline.h quotes that the end point of timeline history entry means
infinity when its value is 0. But that's not completely true, I think
that what is meant here is InvalidXLogRecPtr:
{
TimeLineID tli;
XLogRecPtr begin; /* inclusive */
- XLogRecPtr end; /* exclusive, 0 means
infinity */
+ XLogRecPtr end; /* exclusive,
InvalidXLogRecPtr means
+ * infinity */
} TimeLineHistoryEntry;
And the code leads into this direction as well.
Regards,
--
Michael
| Attachment | Content-Type | Size |
|---|---|---|
| 20150910_timeline_typo.patch | text/x-diff | 489 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fabien COELHO | 2015-09-10 06:34:14 | Re: checkpointer continuous flushing |
| Previous Message | Michael Paquier | 2015-09-10 05:33:15 | Re: Use pg_rewind when target timeline was switched |