Re: Compilation broken when OPTIMIZER_DEBUG is set

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: salvador fandino <sfandino(at)gmail(dot)com>
Cc: PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Subject: Re: Compilation broken when OPTIMIZER_DEBUG is set
Date: 2016-02-29 12:39:33
Message-ID: CAB7nPqSQcSisbugxpDt0nX=W-KCk2HAVP748SQaLG83vFmSmXg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Feb 29, 2016 at 8:44 PM, salvador fandino <sfandino(at)gmail(dot)com> wrote:
> gcc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement
> -Wendif-labels -Wmissing-format-attribute -Wformat-security
> -fno-strict-aliasing -fwrapv -fexcess-precision=standard -g -O0
> -DOPTIMIZER_DEBUG -I../../../../src/include -D_GNU_SOURCE -c -o allpaths.o
> allpaths.c
> allpaths.c: In function ‘debug_print_rel’:
> allpaths.c:2943:50: error: ‘RelOptInfo {aka struct RelOptInfo}’ has no
> member named ‘width’
> printf("): rows=%.0f width=%d\n", rel->rows, rel->width);
> ^
>
> git bisect points to commit 19a541143a09c067ec8cac77ec6a64eb5b1b662b "Add an
> explicit representation of the output targetlist to Paths."

Indeed. The width is now part of rel->reltarget.width. See for example
the attached while I bumped on this email..
--
Michael

Attachment Content-Type Size
optimizer-debug-fix.patch binary/octet-stream 505 bytes

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2016-02-29 12:59:50 Re: RFC: replace pg_stat_activity.waiting with something more descriptive
Previous Message Kouhei Kaigai 2016-02-29 12:07:09 Reworks of CustomScan serialization/deserialization