| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | Ronan Dunklau <ronan(dot)dunklau(at)dalibo(dot)com> |
| Cc: | Albe Laurenz <laurenz(dot)albe(at)wien(dot)gv(dot)at>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: IMPORT FOREIGN SCHEMA statement |
| Date: | 2014-07-03 07:21:19 |
| Message-ID: | CAB7nPqSQRfabxo9YH74u7z1E-Yvd9-YRHDB+oSBHQmtnzEPxBg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Jul 3, 2014 at 3:37 PM, Ronan Dunklau <ronan(dot)dunklau(at)dalibo(dot)com> wrote:
> Also attached in this patch:
> - more robust way for cleaning things up in regression tests
> - small documentation change for options in the fdwhandler API
Those changes look good to me. I have found some minor issues, nothing
really huge so I am updating the patches myself:
- patch 0001 contains the documentation for postgres_fdw: it should be
in 0002, which is missing its docs.
- Some word-smithing as mentioned by Albe previously.
- PQclear before throwing the error "IMPORT of table \"%s\" failed
because of missing type blablah"
With that, I am marking this patch as ready for committer.
--
Michael
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Implement-IMPORT-FOREIGN-SCHEMA-in-core.patch | text/x-patch | 27.4 KB |
| 0002-Add-support-of-IMPORT-FOREIGN-SCHEMA-in-postgres_fdw.patch | text/x-patch | 19.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fabien COELHO | 2014-07-03 08:58:11 | Re: gaussian distribution pgbench |
| Previous Message | Amit Kapila | 2014-07-03 07:20:23 | Re: Autonomous Transaction (WIP) |