| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp> |
| Cc: | PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Duplicate 'use' for TestLib in 001_ssltests.pl |
| Date: | 2016-01-08 07:37:06 |
| Message-ID: | CAB7nPqSP826Rge5fLw43EugW5knZOAhwwHJs9F7YitDKpTsGBA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Jan 8, 2016 at 4:16 PM, Kyotaro HORIGUCHI
<horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp> wrote:
> Hello, I noticed that 001_ssltests.pl uselessly (perhaps) imports
> TestLib twice. Is this intentional? The following change made no
> differences.
>
>
> diff --git a/src/test/ssl/t/001_ssltests.pl b/src/test/ssl/t/001_ssltests.pl
> index 9ce0cf3..cd38e45 100644
> --- a/src/test/ssl/t/001_ssltests.pl
> +++ b/src/test/ssl/t/001_ssltests.pl
> @@ -2,7 +2,6 @@ use strict;
> use warnings;
> use PostgresNode;
> use TestLib;
> -use TestLib;
> use Test::More tests => 38;
> use ServerSetup;
> use File::Copy;
Nice catch. Yes that's an oversight and should be removed.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Magnus Hagander | 2016-01-08 07:54:19 | Re: Duplicate 'use' for TestLib in 001_ssltests.pl |
| Previous Message | amul sul | 2016-01-08 07:35:34 | Re: Bug in MergeAttributesIntoExisting() function. |