From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
---|---|
To: | Ali Akbar <the(dot)apaan(at)gmail(dot)com> |
Cc: | Peter Eisentraut <peter_e(at)gmx(dot)net>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: [REVIEW] Re: Fix xpath() to return namespace definitions |
Date: | 2014-12-15 03:19:15 |
Message-ID: | CAB7nPqSLcjzBhN0=BnEMHi0j5kLh=bPFRVLd8qZHV2kjzOL41Q@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Mon, Dec 15, 2014 at 9:05 AM, Ali Akbar <the(dot)apaan(at)gmail(dot)com> wrote:
> Peter, while reviewing the better performing patch myself, now i think the
> patch needs more work to be committed. The structuring of the method will be
> confusing in the long term. I think I'll restructure the patch in the next
> commitfest.
> So i propose to break the patch:
> 1. We apply the current patch which uses xmlNodeCopy, so that the
> long-standing bug will be fixed in postgres.
> 2. I'll work with the performance enhancement in the next commitfest.
>
> Maybe for (2), the current better-performing patch can be viewed as PoC of
> the expected performance.
Ali, are you currently working on that? Would you mind re-creating new
entries in the commit fest app for the new set of patches that you are
planning to do?
For now I am switching this patch as returned with feedback.
Thanks,
--
Michael
From | Date | Subject | |
---|---|---|---|
Next Message | Andrew Gierth | 2014-12-15 03:25:26 | Re: Add generate_series(numeric, numeric) |
Previous Message | Michael Paquier | 2014-12-15 03:13:38 | Re: WIP: dynahash replacement for buffer table |