Re: Buildfarm TAP testing is useless as currently implemented

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Buildfarm TAP testing is useless as currently implemented
Date: 2015-07-28 01:44:40
Message-ID: CAB7nPqSKxpzTbsq1t828vOp-XKmjgzg4Ri7mJBw3g5jmmfmz4Q@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Jul 28, 2015 at 1:15 AM, Andrew Dunstan <andrew(at)dunslane(dot)net> wrote:
> Well, it does create a lot of files that we don't pick up. An example list
> is show below, and I am attaching their contents in a single gzipped
> attachment. However, these are in the wrong location. This was a vpath build
> and yet these tmp_check directories are all created in the source tree.
> Let's fix that and then I'll set about having the buildfarm collect them.
> That should get us further down the track.
>
> [log list]

The patch attached fixes that. I suggest that we use env{TESTDIR}/log
as a location for the logs so as even a vpath build will locate
correctly the log files.
--
Michael

Attachment Content-Type Size
20150728_tap_logs_vpath.patch binary/octet-stream 563 bytes

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Joe Conway 2015-07-28 02:19:09 Re: A little RLS oversight?
Previous Message David Rowley 2015-07-28 01:14:07 Re: Sharing aggregate states between different aggregate functions