Re: BUG #14109: pg_rewind fails to update target control file in one scenario

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: John Lumby <johnlumby(at)hotmail(dot)com>, Julien Rouhaud <julien(dot)rouhaud(at)dalibo(dot)com>, pgsql bugs <pgsql-bugs(at)postgresql(dot)org>
Subject: Re: BUG #14109: pg_rewind fails to update target control file in one scenario
Date: 2016-04-29 12:08:55
Message-ID: CAB7nPqSJsaQcwn8Z8yDyVNvJUjgg0L+2P7usAHLHZ8TV2ito3g@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

On Fri, Apr 29, 2016 at 8:42 PM, Alvaro Herrera
<alvherre(at)2ndquadrant(dot)com> wrote:
> Well, that sounds like just a SMOP, doesn't it?

Oh, actually, looking at ReplicationSlotReserveWal(), what is used as
a restart LSN is the last redo position. I haven't noticed that until
now. So indded if you create a slot just before the promotion that
would actually be fine.
--
Michael

In response to

Browse pgsql-bugs by date

  From Date Subject
Next Message Mathias Kunter 2016-04-29 12:15:38 Re: BUG #14107: Major query planner bug regarding subqueries and indices
Previous Message Alvaro Herrera 2016-04-29 11:42:16 Re: BUG #14109: pg_rewind fails to update target control file in one scenario