| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | Jeff Janes <jeff(dot)janes(at)gmail(dot)com> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: 9.5rc1 brin_summarize_new_values |
| Date: | 2015-12-26 15:08:46 |
| Message-ID: | CAB7nPqSHjK6-sp4kipj66uq5TBjg4uebohsfvKWLpMn8-qskLQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, Dec 26, 2015 at 7:10 AM, Jeff Janes <jeff(dot)janes(at)gmail(dot)com> wrote:
> brin_summarize_new_values() does not check that it is called on the
> correct type of index, nor does it check permissions.
Yeah, it should have those sanity checks... On top of that this is not
a really user-friendly message:
=# select brin_summarize_new_values('brin_example'::regclass);
ERROR: XX000: cache lookup failed for index 16391
LOCATION: IndexGetRelation, index.c:3279
What do you think about the attached? This should definitely be fixed
by 9.5.0...
--
Michael
| Attachment | Content-Type | Size |
|---|---|---|
| 20151227_brin_new_values_fix.patch | text/x-patch | 3.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2015-12-26 16:06:37 | Re: Performance degradation in commit ac1d794 |
| Previous Message | Andres Freund | 2015-12-26 12:11:14 | Re: Performance degradation in commit ac1d794 |