Re: pg_archivecleanup not deleting anything?

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Albe Laurenz <laurenz(dot)albe(at)wien(dot)gv(dot)at>
Cc: Adrian Klaver <adrian(dot)klaver(at)aklaver(dot)com>, Paul Jungwirth <pj(at)illuminatedcomputing(dot)com>, "pgsql-general(at)postgresql(dot)org" <pgsql-general(at)postgresql(dot)org>
Subject: Re: pg_archivecleanup not deleting anything?
Date: 2015-11-05 04:05:19
Message-ID: CAB7nPqSEokk3KiRq+9x4=-1Zchv5tBk1umyTc7Azz=aMzu8iOg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-general

On Wed, Nov 4, 2015 at 7:16 PM, Albe Laurenz <laurenz(dot)albe(at)wien(dot)gv(dot)at> wrote:
> Michael Paquier wrote:
>>>> The docs mention that "all WAL files" preceding a given point are
>>>> removed, personally I understand that as "all 16MB-size segments shall
>>>> die", hence excluding backup and history files from the stack. But one
>>>> may understand that "WAL files" means everything in pg_xlog, so as
>>>> something that includes backup and history files. Perhaps we would
>>>> gain in clarity by saying "WAL file segments, including .partial
>>>> segments" in the docs, and not just "WAL files". Thoughts?
>>>
>>> It might help to add:
>>> "Timeline history files and backup history files are not deleted."
>>
>> Something among those lines?
>
>> + <para>
>> + WAL file segments and WAL file segments with <literal>.partial</literal>
>> + are deleted, while timeline history files and backup history files are not.
>> + </para>
>
> "WAL file segments with .partial" sounds strange.
> What about "WAL file segments (including partial ones) are deleted, while ..."?

Does that look better?
--
Michael

Attachment Content-Type Size
20151105_archivecleanup_doc_v2.patch text/x-diff 593 bytes

In response to

Responses

Browse pgsql-general by date

  From Date Subject
Next Message Jiří Hlinka 2015-11-05 06:14:17 Re: Deadlock detected after pg_repack receives SIGINT
Previous Message Michael Paquier 2015-11-05 01:57:53 Re: Deadlock detected after pg_repack receives SIGINT