Re: WIP patch for avoiding duplicate initdb runs during "make check"

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Greg Stark <stark(at)mit(dot)edu>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: WIP patch for avoiding duplicate initdb runs during "make check"
Date: 2017-07-03 12:50:45
Message-ID: CAB7nPqS4kDQDc_2G-32udyQTEX=hFgSWQYygMxY83hyrMExDVQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Jul 3, 2017 at 9:25 PM, Greg Stark <stark(at)mit(dot)edu> wrote:
> On 2 July 2017 at 18:33, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> system("cp -a ...") call in favor of something more portable.
>
> If we're ok with using Perl there's File::Copy::Recursive::dircopy()
> which does exactly that.

This stuff needs to support perl down to 5.8.0, and that's a reason
behind having src/test/perl/RecursiveCopy.pm. So I would suggest just
to use that. cp is not portable on Windows as well, that's a recipe
for non-portable code there.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Fabien COELHO 2017-07-03 12:59:55 Re: WIP Patch: Pgbench Serialization and deadlock errors
Previous Message Michael Paquier 2017-07-03 12:46:25 Re: Error-like LOG when connecting with SSL for password authentication