| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
| Cc: | Daniel Verite <daniel(at)manitou-mail(dot)org>, Steve Singer <steve(at)ssinger(dot)info>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Vitaly Burovoy <vitaly(dot)burovoy(at)gmail(dot)com> |
| Subject: | Re: sequence data type |
| Date: | 2017-03-30 01:43:28 |
| Message-ID: | CAB7nPqS0e0o__G=7DaOOTt_CA07KF2mu39FF29wb6gQ0fZsYMQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Mar 30, 2017 at 2:36 AM, Peter Eisentraut
<peter(dot)eisentraut(at)2ndquadrant(dot)com> wrote:
> Over at
> <https://www.postgresql.org/message-id/CAKOSWNnXmM6YBXNzGnXtZQMPjDgJF+a3Wx53Wzmrq5wqDyRX7Q@mail.gmail.com>
> is is being discussed that maybe the behavior when altering the sequence
> type isn't so great, because it currently doesn't update the min/max
> values of the sequence at all. So here is a patch to update the min/max
> values when the old min/max values were the min/max values of the data type.
Looks sane to me. The only comment I have would be to add a test to
trigger as well the code path of reset_min_value with MINVALUE.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Haribabu Kommi | 2017-03-30 02:10:41 | Re: pg_stat_wal_write statistics view |
| Previous Message | Shinoda, Noriyoshi | 2017-03-30 01:30:31 | Re: Partitioning vs ON CONFLICT |