| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | Elvis Pranskevichus <elprans(at)gmail(dot)com> |
| Cc: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pg_dump fails on domain constraint comments |
| Date: | 2016-01-16 14:21:47 |
| Message-ID: | CAB7nPqS=cFyg1nNDyHv-cW4SMdO57hc4n1joXo+fQkwogx5-HQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Jan 12, 2016 at 7:56 AM, Elvis Pranskevichus <elprans(at)gmail(dot)com> wrote:
> It looks like pg_dump emits incorrect text for domain constraint comments:
>
> Assuming the following structure,
Nice catch! qtypname already has fmtId applied to it, so quotes are
applied twice to it in this case. I am adding an entry in the next CF
with patch marked as ready for committer so as this does not fail into
oblivion. A backpatch would be welcome as well.
Here is the patch entry:
https://commitfest.postgresql.org/9/481/
I could not add your name as an author as you visibly do not have a
community account. That's no big deal, I am just mentioning it here to
avoid confusion.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Abhijit Menon-Sen | 2016-01-16 14:48:18 | Re: dealing with extension dependencies that aren't quite 'e' |
| Previous Message | Michael Paquier | 2016-01-16 14:08:40 | Re: exposing pg_controldata and pg_config as functions |