Re: BUG #13741: vacuumdb does not accept valid password

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Haribabu Kommi <kommi(dot)haribabu(at)gmail(dot)com>
Cc: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, brown(at)fastmail(dot)com, "pgsql-bugs(at)postgresql(dot)org" <pgsql-bugs(at)postgresql(dot)org>
Subject: Re: BUG #13741: vacuumdb does not accept valid password
Date: 2015-12-23 13:52:20
Message-ID: CAB7nPqS+W2iUK8YLky+nZtPuQ0RC5MuL0nQuKhLHOtv2yGEogQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

On Mon, Nov 16, 2015 at 11:41 AM, Haribabu Kommi
<kommi(dot)haribabu(at)gmail(dot)com> wrote:
> On Sun, Nov 15, 2015 at 12:39 AM, Michael Paquier
> <michael(dot)paquier(at)gmail(dot)com> wrote:
>> On Fri, Nov 13, 2015 at 6:58 AM, Alvaro Herrera wrote:
>>> Tom Lane wrote:
>>>> Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> writes:
>>>> The place I was thinking we might end up was something like Fujii-san's
>>>> patch plus a new bool parameter "allow_password_reuse", which could be
>>>> passed as false in cases where the old behavior seems preferable.
>>>
>>> Hm, we can try that.
>>
>> That's neater. See for example the attached.
>
> Yes, it is much cleaner than the previous version.
> I reviewed and tested the same. It is working for all scenarios.

This patch has fallen in the void and it simplifies greatly vacuumdb.c
and its password-related routines. I have added it to the next CF to
not forget about it:
https://commitfest.postgresql.org/8/449/
--
Michael

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message foggyglass 2015-12-23 14:55:46 BUG #13830: pg_table_size and pg_indexes_size
Previous Message Maeldron T. 2015-12-22 20:49:56 Re: [BUGS] GIN index isn’t working with intarray

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2015-12-23 13:55:23 Re: pg_hba_lookup function to get all matching pg_hba.conf entries
Previous Message Konstantin Knizhnik 2015-12-23 13:49:38 Re: On columnar storage (2)