Re: Using 128-bit integers for sum, avg and statistics aggregates

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: David Rowley <dgrowleyml(at)gmail(dot)com>
Cc: Andres Freund <andres(at)2ndquadrant(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andreas Karlsson <andreas(at)proxel(dot)se>, Peter Geoghegan <pg(at)heroku(dot)com>, Petr Jelinek <petr(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Using 128-bit integers for sum, avg and statistics aggregates
Date: 2015-03-22 09:42:51
Message-ID: CAB7nPqS+9nNTatMHw4aF-4tq4HMBgB6sCFqXokBDg0aAE2Vt3Q@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sun, Mar 22, 2015 at 6:34 PM, David Rowley <dgrowleyml(at)gmail(dot)com> wrote:
> On 22 March 2015 at 22:22, Andres Freund <andres(at)2ndquadrant(dot)com> wrote:
>>
>> On March 22, 2015 6:17:28 AM GMT+01:00, Michael Paquier
>> <michael(dot)paquier(at)gmail(dot)com> wrote:
>> >On Sun, Mar 22, 2015 at 12:32 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> >> Andres Freund <andres(at)2ndquadrant(dot)com> writes:
>> >>> Pushed with that additional change. Let's see if the buildfarm
>> >thinks.
>> >>
>> >> jacana, apparently alone among buildfarm members, does not like it.
>> >
>> >All the windows nodes don't pass tests with this patch, the difference
>> >is in the exponential precision: e+000 instead of e+00.
>>
>> That's due to a different patch though, right?
>
>
> Yes this is due to cc0d90b.

Err, yes. This exp error is caused by the to_char patch (and that's
what I meant X)), bad copy-paste from here...
--
Michael

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Pavel Stehule 2015-03-22 09:46:02 Re: [PATCH] Add transforms feature
Previous Message Andres Freund 2015-03-22 09:35:34 Re: Using 128-bit integers for sum, avg and statistics aggregates