Re: Hang in pldebugger after git commit : 98a64d0

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Ashutosh Sharma <ashu(dot)coek88(at)gmail(dot)com>
Cc: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Hang in pldebugger after git commit : 98a64d0
Date: 2016-12-14 07:52:23
Message-ID: CAB7nPqRrRwBO7bpUQwZtA=iHnFiH-JJkKmRsqYjN7XT7ZxJi4A@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Dec 14, 2016 at 4:34 PM, Ashutosh Sharma <ashu(dot)coek88(at)gmail(dot)com> wrote:
> Attached is the patch based on Amit's explanation above. Please have a
> look and let me know for any concerns. Thank you Micheal and Andres
> for sharing your thoughts and Amit for your valuable inputs.

}
+ event = &set->events[0];
+ event->events &= ~(WL_SOCKET_READABLE);
#ifndef WIN32

I bet that this patch breaks many things for any non-WIN32 platform.
What I think you want to do is modify the flag events associated to
the socket read/write event to be updated in WaitEventAdjustWin32(),
which gets called in ModifyWaitEvent(). By the way, position 0 refers
to a socket for FeBeWaitSet, but that's a mandatory thing when a list
of events is created with AddWaitEventToSet.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Ashutosh Sharma 2016-12-14 08:38:29 Re: Hang in pldebugger after git commit : 98a64d0
Previous Message Ashutosh Sharma 2016-12-14 07:34:52 Re: Hang in pldebugger after git commit : 98a64d0