Re: pgsql: Retain comments on indexes and constraints at ALTER TABLE ... TY

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Heikki Linnakangas <heikki(dot)linnakangas(at)iki(dot)fi>, pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Retain comments on indexes and constraints at ALTER TABLE ... TY
Date: 2015-07-14 13:24:35
Message-ID: CAB7nPqRngLou0NCrz5qJvGwXk6E0XbV=pqFGfGGVK2u=w7O1+w@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On Tue, Jul 14, 2015 at 10:02 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Heikki Linnakangas <heikki(dot)linnakangas(at)iki(dot)fi> writes:
>> Retain comments on indexes and constraints at ALTER TABLE ... TYPE ...
>
> One or the other of these patches has broken the majority of the
> buildfarm.

Some ORDER BY clauses are missing to make the output consistent it
seems. At the same time the queries could be reformated a bit to not
be longer than 80 characters. A patch is attached.
--
Michael

Attachment Content-Type Size
20150714_fix_altertable.patch application/x-patch 6.7 KB

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Heikki Linnakangas 2015-07-14 13:25:04 pgsql: Make regression test output stable.
Previous Message Tom Lane 2015-07-14 13:02:58 Re: pgsql: Retain comments on indexes and constraints at ALTER TABLE ... TY

Browse pgsql-hackers by date

  From Date Subject
Next Message Heikki Linnakangas 2015-07-14 13:25:46 Re: pgsql: Retain comments on indexes and constraints at ALTER TABLE ... TY
Previous Message sudalai 2015-07-14 13:23:25 Re: First Aggregate Funtion?