| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | Nikita Glukhov <n(dot)gluhov(at)postgrespro(dot)ru> |
| Cc: | Piotr Stefaniak <email(at)piotr-stefaniak(dot)me>, "obartunov(at)gmail(dot)com" <obartunov(at)gmail(dot)com>, Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org>, Teodor Sigaev <teodor(at)postgrespro(dot)ru>, Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru>, andrew Dunstan <andrew(at)dunslane(dot)net> |
| Subject: | Re: [HACKERS] SQL/JSON in PostgreSQL |
| Date: | 2017-11-29 02:24:07 |
| Message-ID: | CAB7nPqRn4NUrQfcbM0GjRBH6kYL0DV8gvFh=eZRKFcL-zPw-3Q@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Nov 15, 2017 at 10:17 AM, Nikita Glukhov
<n(dot)gluhov(at)postgrespro(dot)ru> wrote:
> Attached the new version of the patches where displaying of SQL/JSON
> constructor nodes was fixed. I decided not to invent new nodes but to
> extend
> existing FuncExpr, Aggref, WindowFunc nodes with new formatting fields that
> give us ability to override default displaying in ruleutils.c. Also new
> invisible CoercionForm was added for hiding casts in which FORMAT and
> RETUNING
> clauses are transformed.
Okay, I can see that the patch is still in the same situation two
weeks after I looked at it first, so I am marking it as returned with
feedback. This needs to be broken down, and get documentation. At this
point getting a review out of this patch is not something I'd
recommend until it is put in a shape that makes it easier. Please also
help in reviewing other's patches, yours here is very large.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2017-11-29 02:27:13 | Re: [HACKERS] postgres_fdw: support parameterized foreign joins |
| Previous Message | Andres Freund | 2017-11-29 02:24:00 | Re: [PATCH] Atomic pgrename on Windows |