Re: Silly API for do_pg_start_backup()

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Silly API for do_pg_start_backup()
Date: 2017-12-05 02:05:41
Message-ID: CAB7nPqRmj9yxUPE+=ygUWwAP+yRwBc+w3J+dPTKrjwo0ZBe0EA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Dec 5, 2017 at 3:58 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Barring objection I'll remove the tblspcdir parameter and have
> do_pg_start_backup() open and close the directory immediately
> around the loop where it's read, like every other case in the
> backend.

+1. Thanks for the change. What has been committed in 066bc21 looks good to me..
--
Michael

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2017-12-05 02:15:29 Re: Error handling (or lack of it) in RemovePgTempFilesInDir
Previous Message Michael Paquier 2017-12-05 02:01:30 Re: Error handling (or lack of it) in RemovePgTempFilesInDir