Re: Lack of Sanity Checking in file 'pctcl.c' for PostgreSQL 9.4.x

On Fri, Jun 12, 2015 at 4:22 AM, Bill Parker wrote:
> In reviewing some code, in directory 'postgresql-9.4.3/src/pl/tcl',
> file 'pltcl.c', there are several instances where calls to malloc()
> are made, but no check for a return value of NULL is made, which
> would indicate failure. Additionally, it appears when malloc()
> returns NULL, previously allocated memory in function 'perm_fmgr_info'
> is not released, which could lead to memory leaks (even though the
> comment at the top says 'this routine is a crock' :)
>
> If you know how this problem might be fixed, list the solution below:
> Please feel free to review and comment on the above patch file...

Oh, nice catch again.

> I am attaching the patch file to this bug report

By the way, your patch does not compile properly and is not in-line
with the project's code format. See the updated patch attached ;)
--
Michael