Re: BUG #14849: jsonb_build_object doesn't like VARIADIC calls very much

On Fri, Oct 20, 2017 at 10:49 PM, Andrew Dunstan
<andrew(dot)dunstan(at)2ndquadrant(dot)com> wrote:
>
>
> On 10/19/2017 11:25 AM, Michael Paquier wrote:
>> On Thu, Oct 19, 2017 at 10:13 PM, Andrew Dunstan
>> <andrew(dot)dunstan(at)2ndquadrant(dot)com> wrote:
>>>
>>> On 10/18/2017 10:07 PM, Michael Paquier wrote:
>>>> Please see the attached patch which considers all the discussion done,
>>>> which shapes the code in the way I see most suited for HEAD and
>>>> back-branches.
>>>
>>> Patch doesn't apply against HEAD.
>>>
>>> Also, don't we need more tests?
>> Oops. Sorry about that. v3 is incorrect, I messed up the origin commit
>> for the diffs generated. Here you go as attached.
>
>
> Looks good. Do you want to produce patches for the back branches also?
> this applies to REL_10 but not earlier. If not I'll work on it this weekend.

Here you go, down to 9.4 where things apply. The same patch can be
applied for HEAD/10, 9.5/9.6 and 9.4. The 9.4 version just needs to
have the portion for json as the jsonb functions have been added in
9.5, and the json functions are new as of 9.4.
--
Michael