| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | Fabrízio Mello <fabriziomello(at)gmail(dot)com> |
| Cc: | Aleksandr Parfenov <a(dot)parfenov(at)postgrespro(dot)ru>, Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org>, Yugo Nagata <nagata(at)sraoss(dot)co(dot)jp> |
| Subject: | Re: [PATCH] A hook for session start |
| Date: | 2017-11-04 03:23:32 |
| Message-ID: | CAB7nPqRjZr-Qwrt8bnj=S4PJOwDOrOnaoQ620euK5tGmOhkj1g@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Nov 3, 2017 at 1:55 PM, Fabrízio de Royes Mello
<fabriziomello(at)gmail(dot)com> wrote:
>> Passing the database name and user name does not look much useful to
>> me. You can have access to this data already with CurrentUserId and
>> MyDatabaseId.
>
> This way we don't need to convert oid to names inside hook code.
Well, arguments of hooks are useful if they are used. Now if I look at
the two examples mainly proposed in this thread, be it in your set of
patches or the possibility to do some SQL transaction, I see nothing
using them. So I'd vote for keeping an interface minimal.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Noah Misch | 2017-11-04 07:49:46 | Re: [COMMITTERS] pgsql: Account for catalog snapshot in PGXACT->xmin updates. |
| Previous Message | Michael Paquier | 2017-11-04 03:04:46 | Re: Exclude pg_internal.init from base backup |