| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Craig Ringer <craig(at)2ndquadrant(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Timing-sensitive case in src/test/recovery TAP tests |
| Date: | 2017-08-09 06:45:37 |
| Message-ID: | CAB7nPqRjH5j9Uk=BmJ9j_8-7sqGNqGTFkQrtQACCuqSR7H23qA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Aug 8, 2017 at 11:33 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Michael Paquier <michael(dot)paquier(at)gmail(dot)com> writes:
>> I got the same thought, wondering as well if get_slot_xmins should be
>> renamed check_slot_xmins with the is() tests moved inside it as well.
>> Not sure if that's worth the API ugliness though.
>
> Mmm, doesn't seem like that's worth doing, but I'm half tempted to merge
> wait_slot_xmins into get_slot_xmins so you can't skip it ...
Let's do that please. Merging both was my first feeling when
refactoring this test upthread. Should I send a patch?
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Torsten Zuehlsdorff | 2017-08-09 07:01:44 | Re: Remove 1MB size limit in tsvector |
| Previous Message | Michael Paquier | 2017-08-09 06:42:25 | Re: Re: [COMMITTERS] pgsql: Fix inadequacies in recently added wait events |