| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
| Cc: | Craig Ringer <craig(at)2ndquadrant(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCH] Allow TAP tests to be run individually |
| Date: | 2016-11-14 21:43:07 |
| Message-ID: | CAB7nPqRj-Q1047Z0E=6rJZLk-FZKk-oAqgd6tpzR9aNTyOqHvw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Nov 15, 2016 at 12:02 AM, Peter Eisentraut
<peter(dot)eisentraut(at)2ndquadrant(dot)com> wrote:
> On 11/14/16 3:52 AM, Michael Paquier wrote:
>> I don't mind. This patch uses the following pattern:
>> $(or $(PROVE_TESTS),t/*.pl)
>> While something more spread in Postgres source would be something like that:
>> $(if $(PROVE_TESTS),$(PROVE_TESTS),t/*.pl)
>> It seems to me that we'd prefer that for consistency, but I see no
>> reason to not keep your patch as well. I am marking that as ready for
>> committer.
>
> ($or ...) is a newer feature of GNU make, so we have avoided that so
> far. I have committed your v2 with $(if ...).
Thanks, I am just going to use it...
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2016-11-14 22:10:32 | Re: Do we need use more meaningful variables to replace 0 in catalog head files? |
| Previous Message | Tom Lane | 2016-11-14 21:42:58 | Re: Something is broken about connection startup |