| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Craig Ringer <craig(at)2ndquadrant(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCH] Allow TAP tests to be run individually |
| Date: | 2016-11-14 15:02:13 |
| Message-ID: | 870d7c8b-8dac-d81f-95eb-ecdc2faee8da@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 11/14/16 3:52 AM, Michael Paquier wrote:
> I don't mind. This patch uses the following pattern:
> $(or $(PROVE_TESTS),t/*.pl)
> While something more spread in Postgres source would be something like that:
> $(if $(PROVE_TESTS),$(PROVE_TESTS),t/*.pl)
> It seems to me that we'd prefer that for consistency, but I see no
> reason to not keep your patch as well. I am marking that as ready for
> committer.
($or ...) is a newer feature of GNU make, so we have avoided that so
far. I have committed your v2 with $(if ...).
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2016-11-14 15:07:07 | Re: Partition-wise join for join between (declaratively) partitioned tables |
| Previous Message | Robert Haas | 2016-11-14 14:59:48 | Re: Something is broken about connection startup |