| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Equivalent of --enable-tap-tests in MSVC scripts |
| Date: | 2016-03-01 13:00:23 |
| Message-ID: | CAB7nPqRet6UAP2APhZAZw=VhJ6w-Q-gGLdZkrOqFgd2vc9-ZDw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi all,
As of now the MSVC scripts control if TAP tests are enabled or not
using a boolean flag as $config->{tap_tests}. However, this flag is
just taken into account in vcregress.pl, with the following issues:
1) config_default.pl does not list tap_tests, so it is unclear to
users to enable them. People need to look into vcregress.pl as a start
point.
2) GetFakeConfigure() does not translate $config->{tap_tests} into
--enable-tap-tests, leading to pg_config not reporting it in
CONFIGURE. This is inconsistent with what is done in ./configure.
Attached is a patch to address those two issues.
Regards,
--
Michael
| Attachment | Content-Type | Size |
|---|---|---|
| msvc-fix-tap-flag.patch | binary/octet-stream | 3.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Craig Ringer | 2016-03-01 13:00:45 | Timeline following for logical slots |
| Previous Message | Michael Paquier | 2016-03-01 12:51:32 | Re: [REVIEW] In-core regression tests for replication, cascading, archiving, PITR, etc. |