Re: should we add a XLogRecPtr/LSN SQL type?

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andres Freund <andres(at)2ndquadrant(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Simon Riggs <simon(at)2ndquadrant(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: should we add a XLogRecPtr/LSN SQL type?
Date: 2014-02-05 00:38:04
Message-ID: CAB7nPqRZNKPDUafgi-K1BrKvyL7Ocqg9PeBep525ZDEir3dinA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Feb 5, 2014 at 8:59 AM, Michael Paquier
<michael(dot)paquier(at)gmail(dot)com> wrote:
> I'll update the patches according to that.
Here are the updated patches with the following changes (according to
previous comments):
- Datatype is renamed to pglsn, documentation, file names, regressions
and APIs are updated as well.
- The DatumGet* and *GetDatum APIs are renamed with PGLSN (Should be
PgLsn? But that's a detail)
- pg_create_physical_replication_slot uses PGLSNGetDatum for its 6th argument
For pageinspect, only page_header is impacted and I think that this
should be a separated patch as it makes necessary to dump it to 1.2. I
can write it later once the core parts are decided.
Thanks,
--
Michael

Attachment Content-Type Size
20140205_lsn_datatype_v3.patch text/x-patch 17.7 KB
20140205_lsn_func_cleanup_v2.patch text/x-patch 22.7 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2014-02-05 01:11:54 Re: Minor performance improvement in transition to external sort
Previous Message Peter Geoghegan 2014-02-05 00:24:02 Re: Re: Misaligned BufferDescriptors causing major performance problems on AMD