Re: printing table in asciidoc with psql

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Szymon Guz <mabewlun(at)gmail(dot)com>, Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: printing table in asciidoc with psql
Date: 2015-03-24 02:15:33
Message-ID: CAB7nPqRYdQ6j5XBfdyKGKsvKxHG-17psFbuRxDM2E_b9-HdiEg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Mar 24, 2015 at 8:44 AM, Bruce Momjian wrote:
> Notice the added 'l' next to the '<'. Updated patch attached. Any
> other issues?

Ah, right. That's a good catch and your patch fixes the issue. Still,
there are problems with the tuple-only mode and the expanded mode. For
example using this example (wanted over-complicated):
create table "5 2.2+^.^" ("5 2.2+^.^" text, "4 2.2+^.^" text);
insert into "5 2.2+^.^" values ('5 2.2+^.^', '4 2.2+^.^');
insert into "5 2.2+^.^" values ('2 2.2+^.^', '3 2.2+^.^');
\pset format asciidoc

-- This prints first tuple as a header (which transforms "^.^" to "."
btw), 2nd as a normal row:
=# table "5 2.2+^.^" ;
[options="header",cols="<l,<l",frame="none"]
|====
|5 2.2+^.^ |4 2.2+^.^
|2 2.2+^.^ |3 2.2+^.^
|====
Time: 0.451 ms

And with the expanded mode this has an incorrect format:
=# \x
Expanded display is on.
=# table "5 2.2+^.^" ;

[cols="h,l",frame="none"]
|====
2|
<l|5 2.2+^.^ <|5 2.2+^.^
<l|4 2.2+^.^ <|4 2.2+^.^
2|
<l|5 2.2+^.^ <|2 2.2+^.^
<l|4 2.2+^.^ <|3 2.2+^.^
|====
Time: 0.555 ms

Regards,
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Etsuro Fujita 2015-03-24 02:15:53 Re: inherit support for foreign tables
Previous Message Etsuro Fujita 2015-03-24 02:00:54 Re: Typos in CREATE TABLE doc