Re: scram and \password

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Jeff Janes <jeff(dot)janes(at)gmail(dot)com>, Joe Conway <mail(at)joeconway(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: scram and \password
Date: 2017-04-07 01:42:35
Message-ID: CAB7nPqRY_guD9cGBM7iMnfXw2eJY3gGLhd+0y-opJz8EVdjMHQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Apr 6, 2017 at 8:04 AM, Michael Paquier
<michael(dot)paquier(at)gmail(dot)com> wrote:
> On Thu, Apr 6, 2017 at 2:11 AM, Heikki Linnakangas <hlinnaka(at)iki(dot)fi> wrote:
>> At a quick glance, moving pg_frontend_random() to src/common looks like a
>> non-starter. It uses pglock_thread() which is internal to libpq, so it won't
>> compile as it is. I think I'm going to change scram_build_verifier() to take
>> a pre-generated salt as argument, to avoid the need for a random number
>> generator in src/common.
>
> Oops. Need an updated set of patches?

Attached is an updated set of patches anyway. This is similar to the
last set, except that I removed the part where pg_frontend_random() is
refactored, extending scram_build_verifier() to use a pre-generated
salt.

Hope that helps.
--
Michael

Attachment Content-Type Size
0001-Use-base64-based-encoding-for-stored-and-server-keys.patch application/octet-stream 9.5 KB
0002-Move-routine-to-build-SCRAM-verifier-into-src-common.patch application/octet-stream 9.3 KB
0003-Refactor-frontend-side-random-number-generation.patch application/octet-stream 6.5 KB
0004-Extend-PQencryptPassword-with-a-hashing-method.patch application/octet-stream 5.5 KB
0005-Extend-psql-s-password-and-createuser-to-handle-SCRA.patch application/octet-stream 4.4 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Dunstan 2017-04-07 01:56:05 Re: Time to change pg_regress diffs to unified by default?
Previous Message Tom Lane 2017-04-07 01:41:36 Re: Performance improvement for joins where outer side is unique