Re: Improving log capture of TAP tests with IPC::Run

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>, Andrew Dunstan <andrew(at)dunslane(dot)net>
Subject: Re: Improving log capture of TAP tests with IPC::Run
Date: 2015-07-09 23:52:17
Message-ID: CAB7nPqRYRBpg-uPS3Bup-qvGNN3izMTXqVF4uyYaYBBo5OCn=A@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Jul 9, 2015 at 10:43 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Heikki Linnakangas <hlinnaka(at)iki(dot)fi> writes:
>> Pushed, thanks.
>
> Shouldn't we consider back-patching these improvements into 9.5 and 9.4?
> ISTM the main point is to help debug buildfarm failures, and we won't be
> getting much benefit if only one-third of such reports have decent
> logging.

1ea0620 can be directly cherry-picked on REL9_5_STABLE. For
REL9_4_STABLE the attached looks to work fine.

buildfarm will need to be patched btw... Here is the result of a run
including the log improvements:
http://buildfarm.postgresql.org/cgi-bin/show_stage_log.pl?nm=dangomushi&dt=2015-07-09%2019%3A53%3A02&stg=bin-check
--
Michael

Attachment Content-Type Size
20150710_improve_log_tap_94.patch text/x-diff 11.9 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2015-07-10 01:54:31 Re: Fillfactor for GIN indexes
Previous Message Tom Lane 2015-07-09 23:06:11 Re: WAL logging problem in 9.4.3?