Re: pgsql: Add transforms feature

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: Peter Eisentraut <peter_e(at)gmx(dot)net>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Add transforms feature
Date: 2015-04-28 13:04:37
Message-ID: CAB7nPqRWEgqGQqTc-0bdRTBGbbnPyDEStnOEJw6ffFw=504nhQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On Tue, Apr 28, 2015 at 10:01 AM, Michael Paquier
<michael(dot)paquier(at)gmail(dot)com> wrote:
> On Tue, Apr 28, 2015 at 9:55 AM, Andrew Dunstan wrote:
>> w.r.t MSVC builds, it looks like we need entries in $contrib_extraincludes
>> in src/tools/msvc/Mkvcbuild.pm at the very least.
>
> If our goal is to put back to green the Windows nodes as quick as
> possible, we could bypass their build this way , and we'll
> additionally need to update the install script and
> vcregress.pl/contribcheck to bypass those modules accordingly. Now I
> don't think that we should make the things produced inconsistent.

OK, attached are two patches to put back the buildfarm nodes using MSVC to green
- 0001 adds support for build and installation of the new transform
modules: hstore_plperl, hstore_plpython and ltree_plpython. Note that
this patch is enough to put back the buildfarm to a green state for
MSVC, but it disables the regression tests for those modules,
something addressed in the next patch...
- 0002 adds support for regression tests for the new modules. The
thing is that we need to check the major version version of Python
available in configuration and choose what are the extensions to
preload before the tests run. It is a little bit hacky... But it has
the merit to work, and I am not sure we could have a cleaner solution
by looking at the Makefiles of the transform modules that use
currently conditions based on $(python_majorversion).
Regards,
--
Michael

Attachment Content-Type Size
0001-Fix-MSVC-build-for-transform-modules.patch application/x-patch 13.2 KB
0002-Enable-version-specific-tests-of-plpython-transforms.patch application/x-patch 2.1 KB

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Alvaro Herrera 2015-04-28 14:33:20 pgsql: Protect against multixact members wraparound
Previous Message Tom Lane 2015-04-28 04:05:47 Re: pgsql: Add transforms feature

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2015-04-28 13:09:36 Re: improving speed of make check-world
Previous Message David Fetter 2015-04-28 12:50:28 Re: ATSimpleRecursion() and inheritance foreign parents