Re: pg_basebackup -R

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pg_basebackup -R
Date: 2017-02-15 04:36:52
Message-ID: CAB7nPqROzVSCz3myas4A9ofU615vWteHdU6K=TRq9bzwoUr_Yw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Feb 15, 2017 at 2:38 AM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> On Thu, Feb 9, 2017 at 9:40 PM, Michael Paquier
> <michael(dot)paquier(at)gmail(dot)com> wrote:
>> In short, I'd like to think that we should just filter out those two
>> parameters by name and call it a day. Or introduce an idea of value
>> set for the environment by adding some kind of tracking flag in
>> PQconninfoOption? Though I am not sure that it is worth complicating
>> libpq to just generate recovery.conf in pg_basebackup.
>
> Yeah, I'm not sure what the best solution is. I just thought it was strange.

Thinking more about this, perhaps the correct answer is to do nothing?
target_session_attrs being set is rather similar to sslmode or
sslcompression for example. They are here but don't hurt. The same
thing applies to passfile: if the file is not here the client would
still ask for input. If it is here, things are helped a bit.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2017-02-15 04:43:19 Re: parallelize queries containing subplans
Previous Message Robert Haas 2017-02-15 04:31:56 Re: Documentation improvements for partitioning