| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | hlinnaka(at)iki(dot)fi |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Andrew Dunstan <andrew(at)dunslane(dot)net> |
| Subject: | Re: pg_xlogdump MSVC build script oddities |
| Date: | 2015-03-20 00:15:12 |
| Message-ID: | CAB7nPqRM-H3wfF3YHnYsUPrOHrM7MoG2MZO9uKx73B+otxQ6OA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Mar 19, 2015 at 11:25 AM, Heikki Linnakangas <hlinnaka(at)iki(dot)fi> wrote:
> I'm guessing that the current state of affairs is just an oversight. I tried
> changing it so that xlogreader.c is built into pg_xlogdump without copying,
> and it seemed to work. But I'm using a very recent version of MSVC - perhaps
> it won't work on pre-VS2011 versions.
>
> Unless someone has some insights on this, I'm going to commit the attached,
> and see what the buildfarm thinks of it.
This looks good to me. I just tested your patch on MS 2010, and it
worked, but that's perhaps not old enough to trigger the problem. Now
currawong and mastodon would be the real tests..
Regards,
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2015-03-20 00:18:09 | Re: proposal: doc: simplify examples of dynamic SQL |
| Previous Message | Max Filippov | 2015-03-20 00:14:48 | configure can't detect proper pthread flags |